Skip to content

[PWGCF] FemtoUniverse -- adiing KK invariant mass, adding everything to a new process function - #18588

Draft
zchochul wants to merge 7 commits into
AliceO2Group:masterfrom
zchochul:FemtoUniversepPhi-04-11-2026
Draft

zchochul wants to merge 7 commits into
AliceO2Group:masterfrom
zchochul:FemtoUniversepPhi-04-11-2026

Conversation

@zchochul

@zchochul zchochul commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

New process function was created, because this part of the code turned out to be more costly then expected on resources and the analysis was unable to run on Hyperloop. In this approach, I am doing everything in a separate process function. The code used before can be easily not used with a configurable and as discussed this is a work-around, I plan to come back to the previous version (with the configurable) whenever I am able to solve this issue.

I had very helpful guidance from @vkucera for this PR. Thank you, Vit!

@github-actions github-actions Bot added the pwgcf label Nov 4, 2026
@github-actions github-actions Bot changed the title PWGCF: FemtoUniverse -- adiing KK invariant mass, adding everything to a new process function [PWGCF] FemtoUniverse -- adiing KK invariant mass, adding everything to a new process function Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 22 warnings, 🔕 0 disabled

@majanik
majanik enabled auto-merge (squash) November 4, 2026 14:37
majanik
majanik previously approved these changes Nov 4, 2026
@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 41d2d0f at 2026-11-04 15:43:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:788:64: error: unused parameter 'parts' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@zchochul
zchochul requested a review from majanik November 4, 2026 14:46
@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 41d2d0f at 2026-11-04 15:50:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 0 warnings.'
Found 2 errors and 0 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/6950d21cf9f9bd38473b4e766c6a1543c4bc7ff9/O2Physics-code-check/errors.txt
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:788:64: error: parameter 'parts' is unused [misc-unused-parameters,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:788:64: error: unused parameter 'parts' [clang-diagnostic-unused-parameter,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 41d2d0f at 2026-11-04 15:51:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:788:64: error: unused parameter 'parts' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

majanik
majanik previously approved these changes Nov 4, 2026
@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ea31afb at 2026-11-04 16:02:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/daily-20261104-0000-local1/include/Framework/AnalysisTask.h:738:60: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::invokeProcess(std::__shared_ptr<FemtoUniversePairTaskTrackPhi, __gnu_cxx::_S_atomic>::element_type&, o2::framework::InputRecord&, std::vector<std::pair<int, o2::framework::ConcreteDataMatcher> >&, o2::framework::PointerReconstructor&, void (FemtoUniversePairTaskTrackPhi::*&)(), std::vector<ExpressionInfo>&, o2::framework::ArrowTableSlicingCache&, o2::header::DataOrigin&)'
/sw/slc9_x86-64/O2/daily-20261104-0000-local1/include/Framework/AnalysisTask.h:193:48: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::cacheFromArgs(void (FemtoUniversePairTaskTrackPhi::*&)(), bool&, o2::framework::Cache&, o2::framework::Cache&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for ea31afb at 2026-11-04 16:03:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/daily-20261104-0000-local2/include/Framework/AnalysisTask.h:738:60: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::invokeProcess(std::__shared_ptr<FemtoUniversePairTaskTrackPhi, __gnu_cxx::_S_atomic>::element_type&, o2::framework::InputRecord&, std::vector<std::pair<int, o2::framework::ConcreteDataMatcher> >&, o2::framework::PointerReconstructor&, void (FemtoUniversePairTaskTrackPhi::*&)(), std::vector<ExpressionInfo>&, o2::framework::ArrowTableSlicingCache&, o2::header::DataOrigin&)'
/sw/slc9_x86-64/O2/daily-20261104-0000-local2/include/Framework/AnalysisTask.h:193:48: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::cacheFromArgs(void (FemtoUniversePairTaskTrackPhi::*&)(), bool&, o2::framework::Cache&, o2::framework::Cache&)'
ninja: build stopped: subcommand failed.

Full log here.

@zchochul
zchochul force-pushed the FemtoUniversepPhi-04-11-2026 branch from ea31afb to 1c54842 Compare November 4, 2026 15:16
@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 2fdd6a2 at 2026-11-04 16:29:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:788:30: error: expected identifier before '(' token
/sw/slc9_x86-64/O2/daily-20261104-0000-local1/include/Framework/AnalysisTask.h:738:60: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::invokeProcess(std::__shared_ptr<FemtoUniversePairTaskTrackPhi, __gnu_cxx::_S_atomic>::element_type&, o2::framework::InputRecord&, std::vector<std::pair<int, o2::framework::ConcreteDataMatcher> >&, o2::framework::PointerReconstructor&, void (FemtoUniversePairTaskTrackPhi::*&)(int (*)(const o2::soa::Join<o2::soa::Table<o2::aod::Hash<1787194093>, o2::aod::Hash<3593260883>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2933573502>, o2::aod::Hash<558040367>, o2::aod::Hash<2286545062> > >&)), std::vector<ExpressionInfo>&, o2::framework::ArrowTableSlicingCache&, o2::header::DataOrigin&)'
/sw/slc9_x86-64/O2/daily-20261104-0000-local1/include/Framework/AnalysisTask.h:182:49: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::inputsFromArgs(void (FemtoUniversePairTaskTrackPhi::*&)(int (*)(const o2::soa::Join<o2::soa::Table<o2::aod::Hash<1787194093>, o2::aod::Hash<3593260883>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2933573502>, o2::aod::Hash<558040367>, o2::aod::Hash<2286545062> > >&)), const char*, bool&, std::vector<o2::framework::InputSpec>&, std::vector<ExpressionInfo>&, std::vector<o2::framework::InputInfo>&, o2::header::DataOrigin&)'
/sw/slc9_x86-64/O2/daily-20261104-0000-local1/include/Framework/AnalysisTask.h:193:48: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::cacheFromArgs(void (FemtoUniversePairTaskTrackPhi::*&)(int (*)(const o2::soa::Join<o2::soa::Table<o2::aod::Hash<1787194093>, o2::aod::Hash<3593260883>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2933573502>, o2::aod::Hash<558040367>, o2::aod::Hash<2286545062> > >&)), bool&, o2::framework::Cache&, o2::framework::Cache&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 2fdd6a2 at 2026-11-04 16:30:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:788:30: error: expected identifier before '(' token
/sw/slc9_x86-64/O2/daily-20261104-0000-local1/include/Framework/AnalysisTask.h:738:60: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::invokeProcess(std::__shared_ptr<FemtoUniversePairTaskTrackPhi, __gnu_cxx::_S_atomic>::element_type&, o2::framework::InputRecord&, std::vector<std::pair<int, o2::framework::ConcreteDataMatcher> >&, o2::framework::PointerReconstructor&, void (FemtoUniversePairTaskTrackPhi::*&)(int (*)(const o2::soa::Join<o2::soa::Table<o2::aod::Hash<1787194093>, o2::aod::Hash<3593260883>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2933573502>, o2::aod::Hash<558040367>, o2::aod::Hash<2286545062> > >&)), std::vector<ExpressionInfo>&, o2::framework::ArrowTableSlicingCache&, o2::header::DataOrigin&)'
/sw/slc9_x86-64/O2/daily-20261104-0000-local1/include/Framework/AnalysisTask.h:182:49: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::inputsFromArgs(void (FemtoUniversePairTaskTrackPhi::*&)(int (*)(const o2::soa::Join<o2::soa::Table<o2::aod::Hash<1787194093>, o2::aod::Hash<3593260883>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2933573502>, o2::aod::Hash<558040367>, o2::aod::Hash<2286545062> > >&)), const char*, bool&, std::vector<o2::framework::InputSpec>&, std::vector<ExpressionInfo>&, std::vector<o2::framework::InputInfo>&, o2::header::DataOrigin&)'
/sw/slc9_x86-64/O2/daily-20261104-0000-local1/include/Framework/AnalysisTask.h:193:48: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::cacheFromArgs(void (FemtoUniversePairTaskTrackPhi::*&)(int (*)(const o2::soa::Join<o2::soa::Table<o2::aod::Hash<1787194093>, o2::aod::Hash<3593260883>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2933573502>, o2::aod::Hash<558040367>, o2::aod::Hash<2286545062> > >&)), bool&, o2::framework::Cache&, o2::framework::Cache&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 2fdd6a2 at 2026-11-04 16:31:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:788:30: error: expected identifier before '(' token
/sw/slc9_x86-64/O2/daily-20261104-0000-local1/include/Framework/AnalysisTask.h:738:60: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::invokeProcess(std::__shared_ptr<FemtoUniversePairTaskTrackPhi, __gnu_cxx::_S_atomic>::element_type&, o2::framework::InputRecord&, std::vector<std::pair<int, o2::framework::ConcreteDataMatcher> >&, o2::framework::PointerReconstructor&, void (FemtoUniversePairTaskTrackPhi::*&)(int (*)(const o2::soa::Join<o2::soa::Table<o2::aod::Hash<1787194093>, o2::aod::Hash<3593260883>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2933573502>, o2::aod::Hash<558040367>, o2::aod::Hash<2286545062> > >&)), std::vector<ExpressionInfo>&, o2::framework::ArrowTableSlicingCache&, o2::header::DataOrigin&)'
/sw/slc9_x86-64/O2/daily-20261104-0000-local1/include/Framework/AnalysisTask.h:182:49: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::inputsFromArgs(void (FemtoUniversePairTaskTrackPhi::*&)(int (*)(const o2::soa::Join<o2::soa::Table<o2::aod::Hash<1787194093>, o2::aod::Hash<3593260883>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2933573502>, o2::aod::Hash<558040367>, o2::aod::Hash<2286545062> > >&)), const char*, bool&, std::vector<o2::framework::InputSpec>&, std::vector<ExpressionInfo>&, std::vector<o2::framework::InputInfo>&, o2::header::DataOrigin&)'
/sw/slc9_x86-64/O2/daily-20261104-0000-local1/include/Framework/AnalysisTask.h:193:48: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::cacheFromArgs(void (FemtoUniversePairTaskTrackPhi::*&)(int (*)(const o2::soa::Join<o2::soa::Table<o2::aod::Hash<1787194093>, o2::aod::Hash<3593260883>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2933573502>, o2::aod::Hash<558040367>, o2::aod::Hash<2286545062> > >&)), bool&, o2::framework::Cache&, o2::framework::Cache&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for ea31afb at 2026-11-04 16:34:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/daily-20261104-0000-local1/include/Framework/AnalysisTask.h:738:60: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::invokeProcess(std::__shared_ptr<FemtoUniversePairTaskTrackPhi, __gnu_cxx::_S_atomic>::element_type&, o2::framework::InputRecord&, std::vector<std::pair<int, o2::framework::ConcreteDataMatcher> >&, o2::framework::PointerReconstructor&, void (FemtoUniversePairTaskTrackPhi::*&)(), std::vector<ExpressionInfo>&, o2::framework::ArrowTableSlicingCache&, o2::header::DataOrigin&)'
/sw/slc9_x86-64/O2/daily-20261104-0000-local1/include/Framework/AnalysisTask.h:193:48: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::cacheFromArgs(void (FemtoUniversePairTaskTrackPhi::*&)(), bool&, o2::framework::Cache&, o2::framework::Cache&)'
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
vkucera marked this pull request as draft November 4, 2026 18:20
auto-merge was automatically disabled November 4, 2026 18:20

Pull request was converted to draft


PROCESS_SWITCH(FemtoUniversePairTaskTrackPhi, processMCReco, "Process MC reco data", false);

void processMinvBackground(([[maybe_unused]] FilteredFemtoFullParticles const& parts))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parts is never used. Why do you not just remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants